Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(template): add createdAt and updatedAt to example model #619

Merged
merged 6 commits into from
Oct 18, 2022
Merged

feat(template): add createdAt and updatedAt to example model #619

merged 6 commits into from
Oct 18, 2022

Conversation

nexxeln
Copy link
Member

@nexxeln nexxeln commented Oct 17, 2022

Closes #618

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Added createdAt and updatedAt to Example prisma model.

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: dc16c9b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Oct 18, 2022 at 2:32AM (UTC)

@github-actions github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Oct 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 93
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-nexxel-add-timestamps-to-example-model-t3-oss.vercel.app/

@nexxeln
Copy link
Member Author

nexxeln commented Oct 17, 2022

I also have to format. Don't merge before I push that commit.

@juliusmarminge
Copy link
Member

I also have to format. Don't merge before I push that commit.

Wow why so large diff? Sure thats the correct formatting?

@nexxeln
Copy link
Member Author

nexxeln commented Oct 17, 2022

I also have to format. Don't merge before I push that commit.

Wow why so large diff? Sure thats the correct formatting?

I ran npx prisma format

@nexxeln
Copy link
Member Author

nexxeln commented Oct 17, 2022

I also have to format. Don't merge before I push that commit.

Wow why so large diff? Sure thats the correct formatting?

I guess its 2 spaces instead of 4.

c-ehrlich
c-ehrlich approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. i don't mind the schema diff, has to be done in some commit sooner or later anyway

@nexxeln nexxeln merged commit 1122720 into next Oct 18, 2022
@nexxeln nexxeln deleted the nexxel/add-timestamps-to-example-model branch October 18, 2022 03:35
@github-actions github-actions bot mentioned this pull request Oct 18, 2022
Merged
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@nexxeln @c-ehrlich
feat(template): add createdAt and updatedAt to example model (t3-oss#619
9e771e1 
)

* feat(template): add createdAt and updatedAt to example model

* Create hot-stingrays-live.md

* chore: format

* chore: run npx prisma format again

Co-authored-by: Christopher Ehrlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge juliusmarminge approved these changes

@c-ehrlich c-ehrlich c-ehrlich approved these changes

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

Assignees
No one assigned
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add createAt and updatedAt to the prisma models
3 participants
@nexxeln @juliusmarminge @c-ehrlich