Skip to content

feat: add more scripts #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 16, 2024
Merged

feat: add more scripts #1997

merged 6 commits into from
Oct 16, 2024

Conversation

programming-with-ia
Copy link
Contributor

Closes #1981

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

More Scripts added in cli/template/base/package.json

  • lint:fix
  • check
  • preview
  • typecheck
  • format:write
  • format:check

Screenshots

cli/template/base/package.json
image

💯

@programming-with-ia
add more scripts
1567a48 
`lint:fix`
`check`
`preview`
`typecheck`
`format:write`
`format:check`
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 29b7590

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 1 unresolved
✅ 1 resolved		 Oct 16, 2024 11:58am

@vercel Vercel
Copy link

vercel bot commented Oct 16, 2024

@programming-with-ia is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@programming-with-ia programming-with-ia mentioned this pull request Oct 16, 2024
Closed
programming-with-ia

This comment was marked as off-topic.

Sign in to view

juliusmarminge
juliusmarminge requested changes Oct 16, 2024
View reviewed changes
cli/template/base/package.json Outdated
Comment on lines 15 to 16
"format:write": "prettier --write \"**/*.{ts,tsx,js,jsx,mdx}\" --cache",
"format:check": "prettier --check \"**/*.{ts,tsx,js,jsx,mdx}\" --cache"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all templates gets prettier installed, only if you have tailwind iirc so this wouldn't work ootb

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback! Just to clarify, would you like me to remove the scripts entirely, or would you prefer that I integrate them through tailwind.ts instead, similar to this example? I'm happy to make the adjustments based on your preference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modify cli\src\installers\tailwind.ts
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea similar to how the db installers adds the db:push scripts etc this can for now be handled in the tailwind installeer if/until there're more formatting options

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliusmarminge

Done ✅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to run pnpm format in root. there are formatting issues in the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliusmarminge Done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to run changeset add --empty or changeset add?

Copy link
Member

@juliusmarminge juliusmarminge Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Read the contributing guide (you checked the box when creating the PR ☺️)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Read the contributing guide (you checked the box when creating the PR ☺️)

🙏 🫡😔

@programming-with-ia programming-with-ia changed the title add more scripts feat: add more scripts Oct 16, 2024
@juliusmarminge juliusmarminge mentioned this pull request Oct 16, 2024
Closed
@juliusmarminge juliusmarminge merged commit fe85a23 into t3-oss:main Oct 16, 2024
265 of 266 checks passed
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge juliusmarminge approved these changes

@nexxeln nexxeln Awaiting requested review from nexxeln nexxeln is a code owner

@t3dotgg t3dotgg Awaiting requested review from t3dotgg t3dotgg is a code owner

@c-ehrlich c-ehrlich Awaiting requested review from c-ehrlich c-ehrlich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add more scripts in package.json
2 participants
@programming-with-ia @juliusmarminge