Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undo env changes #1084

Merged
merged 4 commits into from
Jan 15, 2023
Merged

fix: undo env changes #1084

merged 4 commits into from
Jan 15, 2023

Conversation

c-ehrlich
Copy link
Member

@c-ehrlich c-ehrlich commented Jan 15, 2023

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

#1069 has an issue that breaks client .env

I would like to keep all of the changes from that PR including a fixed version of the client stuff, but as a quick fix its easiest to just revert. We can add it back more carefully afterwards.


💯

@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2023

🦋 Changeset detected

Latest commit: f84a0f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
create-t3-app ⬜️ Ignored (Inspect) Jan 15, 2023 at 2:18PM (UTC)

@github-actions github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App 📚 documentation Improvements or additions to documentation labels Jan 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 100
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-revert-env-changes-t3-oss.vercel.app/

@juliusmarminge
Copy link
Member

Agree, it also doesn't work in Edge Runtimes I noticed

@juliusmarminge juliusmarminge enabled auto-merge (squash) January 15, 2023 14:19
@juliusmarminge juliusmarminge merged commit 7490a34 into next Jan 15, 2023
@juliusmarminge juliusmarminge deleted the revert-env-changes branch January 15, 2023 14:23
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App 📚 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants