Skip to content

Add ComboboxOption interface #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add ComboboxOption interface #716

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
db11b13
Add ComboboxOption interface
fjaguado Mar 1, 2023
ab59908
Update documentation of the combobox
fjaguado Mar 1, 2023
861422c
Update package version
fjaguado Mar 1, 2023
7e8d4d8
ESlint fixings
fjaguado Mar 31, 2023
e628eeb
ESLint fixings
fjaguado Mar 31, 2023
a6c81b3
ESlint fixing
fjaguado Apr 14, 2023
0a249b3
Merge branch 'master' into feature-715
fjaguado Feb 5, 2024
5df9015
Fix test
fjaguado Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion projects/showcase/src/app/components/combobox/showcase-autocomplete-combobox.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { ChangeDetectorRef, Component, Renderer2 } from '@angular/core';
import { AutocompleteApiComboBox } from 'systelab-components';
import { Observable, of } from 'rxjs';
import { ComboboxOption } from "../../../../../systelab-components/src/lib/combobox/combobox-option.interface";

export class ShowcaseCities {
public id: string;
Expand All @@ -15,7 +16,7 @@ export class ShowcaseCities {

export class ShowcaseAutocomplete extends AutocompleteApiComboBox<ShowcaseCities> {

public defaultValues = [
public defaultValues: ComboboxOption<string>[] = [
{description: 'New York', id: '1'},
{description: 'Rome', id: '2'},
{description: 'London', id: '3'},
Expand Down
32 changes: 16 additions & 16 deletions projects/showcase/src/app/components/combobox/showcase-combobox.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="container-fluid">
<div class="row mt-1">
<label class="col-md-3 col-form-label" for="form-h-s">Sin buscador</label>
<label class="col-md-3 col-form-label">Sin buscador</label>
<div class="col-md-9">
<systelab-select
[values]="comboOptionList"
Expand All @@ -9,7 +9,7 @@
</div>
</div>
<div class="row mt-1">
<label class="col-md-3 col-form-label" for="form-h-s">With restore default option</label>
<label class="col-md-3 col-form-label">With restore default option</label>
<div class="col-md-9">
<systelab-select
[values]="comboOptionList"
Expand All @@ -19,7 +19,7 @@
</div>
</div>
<div class="row mt-1">
<label class="col-md-3 col-form-label" for="form-h-s">With restore default option (rubbish icon instead of X) and empty element in the list</label>
<label class="col-md-3 col-form-label">With restore default option (rubbish icon instead of X) and empty element in the list</label>
<div class="col-md-9">
<systelab-select
[withEmptyValue]="true"
Expand All @@ -31,14 +31,14 @@
</div>
</div>
<div class="row mt-1">
<label class="col-md-3 col-form-label" for="form-h-s">Autocomplete</label>
<label class="col-md-3 col-form-label">Autocomplete</label>
<div class="col-md-9">
<showcase-autocomplete (selectedItemChange)="comboChangeEvent($event)">
</showcase-autocomplete>
</div>
</div>
<div class="row mt-1">
<label class="col-md-3 col-form-label" for="form-h-s">Editable input</label>
<label class="col-md-3 col-form-label">Editable input</label>
<div class="col-md-9">
<systelab-select
[allowEditInput]="true"
Expand All @@ -48,7 +48,7 @@
</div>
</div>
<div class="row mt-1">
<label class="col-md-3 col-form-label" for="form-h-s">Combo with Icon and color</label>
<label class="col-md-3 col-form-label">Combo with Icon and color</label>
<div class="col-md-9">
<systelab-select
[withIcon]="true"
Expand All @@ -61,7 +61,7 @@
</div>
</div>
<div class="row mt-1">
<label class="col-md-3 col-form-label" for="form-h-s">Favoritos</label>
<label class="col-md-3 col-form-label">Favoritos</label>
<div class="col-md-9">
<systelab-select
[values]="comboOptionList"
Expand All @@ -72,7 +72,7 @@
</div>
</div>
<div class="row mt-1">
<label class="col-md-3 col-form-label" for="form-h-s">Disabled</label>
<label class="col-md-3 col-form-label">Disabled</label>
<div class="col-md-9">
<systelab-select
[values]="comboOptionList"
Expand All @@ -82,7 +82,7 @@
</div>
</div>
<div class="row mt-1">
<label class="col-md-3 col-form-label" for="form-h-s">Con valor asignado</label>
<label class="col-md-3 col-form-label">Con valor asignado</label>
<div class="col-md-9">
<systelab-select
[id]="1"
Expand All @@ -92,7 +92,7 @@
</div>
</div>
<div class="row mt-1">
<label class="col-md-3 col-form-label" for="form-h-s">Con buscador</label>
<label class="col-md-3 col-form-label">Con buscador</label>
<div class="col-md-9">
<systelab-select
[values]="comboOptionList" [filter]="true"
Expand All @@ -101,36 +101,36 @@
</div>
</div>
<div class="row mt-1">
<label class="col-md-3 col-form-label" for="form-h-s">Color Picker</label>
<label class="col-md-3 col-form-label">Color Picker</label>
<div class="col-md-9">
<systelab-colorpicker
[(id)]="colorId">
</systelab-colorpicker>
</div>
</div>
<div class="row mt-1">
<label class="col-md-3 col-form-label" for="form-h-s">All Yes-No</label>
<label class="col-md-3 col-form-label">All Yes-No</label>
<div class="col-md-9">
<systelab-all-yes-no-select>
</systelab-all-yes-no-select>
</div>
</div>
<div class="row mt-1">
<label class="col-md-3 col-form-label" for="form-h-s">Gender</label>
<label class="col-md-3 col-form-label">Gender</label>
<div class="col-md-9">
<systelab-gender-select>
</systelab-gender-select>
</div>
</div>
<div class="row mt-1">
<label class="col-md-3 col-form-label" for="form-h-s">Time unit</label>
<label class="col-md-3 col-form-label">Time unit</label>
<div class="col-md-9">
<systelab-time-unit-select>
</systelab-time-unit-select>
</div>
</div>
<div class="row mt-1">
<label class="col-md-3 col-form-label" for="form-h-s">Multiple Selection</label>
<label class="col-md-3 col-form-label">Multiple Selection</label>
<div class="col-md-9">
<systelab-select
[multipleSelection]="multiple"
Expand All @@ -144,7 +144,7 @@
</div>
</div>
<div class="row mt-1">
<label class="col-md-3 col-form-label" for="form-h-s">Tree Combobox with favourites</label>
<label class="col-md-3 col-form-label">Tree Combobox with favourites</label>
<div class="col-md-9">
<showcase-inner-tree-combobox [withFavourites]="true"
[preferenceName]="'favourites.section-laboratory-combobox'"></showcase-inner-tree-combobox>
Expand Down
7 changes: 4 additions & 3 deletions projects/showcase/src/app/components/combobox/showcase-combobox.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {Component} from '@angular/core';
import { Component } from '@angular/core';
import { ComboboxOption } from "../../../../../systelab-components/src/lib/combobox/combobox-option.interface";

@Component({
selector: 'showcase-combobox',
Expand All @@ -11,9 +12,9 @@ export class ShowcaseComboboxComponent {
public listSelectedValues = true;
public multiple = true;

public comboOptionList: Array<Object> = [];
public comboOptionList: ComboboxOption<number>[] = [];

public selectedComboOptionList: Array<Object> = [];
public selectedComboOptionList: ComboboxOption<number>[] = [];

constructor() {

Expand Down
2 changes: 1 addition & 1 deletion projects/systelab-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "systelab-components",
"version": "15.1.0",
"version": "15.1.1",
"license": "MIT",
"keywords": [
"Angular",
Expand Down
Loading