Add ComboboxOption interface #716
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #716 +/- ##
==========================================
- Coverage 56.54% 54.23% -2.31%
==========================================
Files 129 125 -4
Lines 3631 3470 -161
Branches 639 601 -38
==========================================
- Hits 2053 1882 -171
- Misses 1468 1484 +16
+ Partials 110 104 -6 ☔ View full report in Codecov by Sentry. |
carlosra85
previously approved these changes
Apr 14, 2023
pepgrifell
previously approved these changes
Apr 14, 2023
| public getData(page: number, itemsPerPage: number): Observable<Array<Combobox<string | number>>> { | ||
| return this.api.getLaboratoryList(page,itemsPerPage).pipe(map((value) => { | ||
| this.totalItems = value.totalElements; | ||
| return value.content; |
There was a problem hiding this comment.
Do we receive an array of Combobox<string | number> from API ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
A new ComboboxOption interface has been added.
Description
To be able to assure the consistency of the data passed to the combobox, a new interface has been added to be used to type data in the options array.
Related Issue
#715
Motivation and Context
Reinforce type driven development
Types of changes
Checklist