Skip to content

Test/ios tags #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jvsena42 merged 5 commits into from
Nov 24, 2025
Merged

Test/ios tags #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2526af3
adjust tag ids
piotr-iohk Nov 21, 2025
5fc36e4
SheetIntro adjustment
piotr-iohk Nov 21, 2025
dba5411
Tags Add
piotr-iohk Nov 24, 2025
0085448
calendar
piotr-iohk Nov 24, 2025
742ec9c
enable onchain_2
piotr-iohk Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ jobs:
# - { name: onchain_boost_receive_widgets, grep: "@onchain|@boost|@receive|@widgets" }
# - { name: settings, grep: "@settings" }
# - { name: security, grep: "@security" }
- { name: e2e, grep: '^(?!.*@settings_10)(@onboarding|@onchain_1|@numberpad|@widgets|@boost|@receive|@settings|@security)' }
- { name: e2e, grep: '^(?!.*@settings_10)(@onboarding|@onchain_1|@onchain_2|@numberpad|@widgets|@boost|@receive|@settings|@security)' }

name: e2e-tests - ${{ matrix.shard.name }}

Expand Down
2 changes: 2 additions & 0 deletions Bitkit/Components/Activity/ActivityListFilter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,15 @@ struct ActivityListFilter: View {
.onTapGesture {
showingTagSelector = true
}
.accessibilityIdentifier("TagsPrompt")
Image("calendar")
.resizable()
.frame(width: 24, height: 24)
.foregroundColor(viewModel.startDate != nil ? .brandAccent : .white64)
.onTapGesture {
showingDateRange = true
}
.accessibilityIdentifier("DatePicker")
}
}
.frame(width: .infinity, height: 48)
Expand Down
1 change: 1 addition & 0 deletions Bitkit/Components/Activity/DateRangeSelectorSheet.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ struct DateRangeSelectorSheet: View {
startDate = nil
endDate = nil
viewModel.clearDateRange()
isPresented = false
Copy link
Contributor

@pwltr pwltr Nov 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing the calendar selection is not supposed to close the sheet UX wise, see current Bitkit app

Copy link
Collaborator Author

@piotr-iohk piotr-iohk Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks, I will fix this in ios and android and update e2e tests accordingly.

}
.accessibilityIdentifier("CalendarClearButton")

Expand Down
1 change: 1 addition & 0 deletions Bitkit/Components/SegmentedControl.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ struct SegmentedControl<T: Hashable & CustomStringConvertible>: View {
.contentShape(Rectangle())
}
.buttonStyle(PlainButtonStyle())
.accessibilityIdentifier("Tab-\(tabItem.tab.description.lowercased())")
}
}
.frame(maxWidth: .infinity)
Expand Down
4 changes: 2 additions & 2 deletions Bitkit/Components/SheetIntro.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,15 +91,15 @@ struct SheetIntro: View {
) {
onContinue()
}
.accessibilityIdentifier("\(baseTestID)-button-continue")
.accessibilityIdentifier("\(baseTestID)Continue")
}
} else {
CustomButton(
title: continueText
) {
onContinue()
}
.accessibilityIdentifier("\(baseTestID)-button-continue")
.accessibilityIdentifier("\(baseTestID)Continue")
}
}
}
3 changes: 2 additions & 1 deletion Bitkit/Components/Tag.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,15 @@ struct Tag: View {
)
.cornerRadius(8)
.fixedSize(horizontal: true, vertical: false)
.accessibilityElement(children: .contain)
.accessibilityIdentifier("Tag-\(value)")
}

var body: some View {
if let onPress {
Button(action: onPress) {
tagContent
}
.accessibilityIdentifier("Tag-\(value)")
.buttonStyle(.plain) // Use plain button style to avoid default button appearance interfering
} else {
tagContent
Expand Down
3 changes: 2 additions & 1 deletion Bitkit/Views/Wallets/Send/SendConfirmationView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ struct SendConfirmationView: View {
},
onAddTag: {
navigationPath.append(.tag)
}
},
buttonTestId: "TagsAddSend"
)

Spacer()
Expand Down
4 changes: 3 additions & 1 deletion Bitkit/Views/Wallets/Send/SendTagScreen.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ struct SendTagScreen: View {

TagInputForm(
tagText: $newTagText,
isTextFieldFocused: $isTextFieldFocused
isTextFieldFocused: $isTextFieldFocused,
textFieldTestId: "TagInputSend",
buttonTestId: "SendTagsSubmit"
) { tag in
await addTag(tag)
}
Expand Down
Loading