Test/ios tags #240
Merged
Test/ios tags #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the @onchain_2 end-to-end test suite after a bug fix in the iOS codebase, and improves UI test automation by adding accessibility identifiers and standardizing their naming conventions.
Key Changes:
- Enables
@onchain_2test tag in the e2e test workflow - Adds accessibility identifiers to tag-related components for better test automation coverage
- Standardizes test ID naming by removing hyphens (e.g.,
-button-continue→Continue) - Improves UX by dismissing the date range selector sheet when clearing the selection
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/e2e-tests.yml | Adds @onchain_2 to the enabled test tags in the e2e test grep pattern |
| Bitkit/Views/Wallets/Send/SendTagScreen.swift | Adds test identifiers TagInputSend and SendTagsSubmit to the tag input form |
| Bitkit/Views/Wallets/Send/SendConfirmationView.swift | Adds TagsAddSend test identifier to the add tag button |
| Bitkit/Components/Tag.swift | Moves accessibility identifier from button to tagContent view builder for better test coverage of both tappable and non-tappable tags |
| Bitkit/Components/SheetIntro.swift | Standardizes button test IDs by removing -button- prefix (e.g., Continue instead of -button-continue) |
| Bitkit/Components/SegmentedControl.swift | Adds accessibility identifier to segmented control tabs using format Tab-{description} |
| Bitkit/Components/Activity/DateRangeSelectorSheet.swift | Dismisses sheet when clearing date range for improved UX consistency |
| Bitkit/Components/Activity/ActivityListFilter.swift | Adds test identifiers TagsPrompt and DatePicker to filter icons |
jvsena42
approved these changes
Nov 24, 2025
pwltr
reviewed
Nov 25, 2025
| startDate = nil | ||
| endDate = nil | ||
| viewModel.clearDateRange() | ||
| isPresented = false |
Contributor
There was a problem hiding this comment.
Clearing the calendar selection is not supposed to close the sheet UX wise, see current Bitkit app
Collaborator
Author
There was a problem hiding this comment.
Ok, thanks, I will fix this in ios and android and update e2e tests accordingly.
This was referenced Nov 25, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr enables
onchain_2test after #197 has been fixed.Some other minor changes related to adjustments in tests.
Linked Issues/Tasks
Screenshot / Video
Insert relevant screenshot / recording