leveldb: add write delay statistic#193
Closed
rjl493456442 wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
@syndtr PTAL :) |
rjl493456442
force-pushed
the
record_write_pause
branch
from
f654e8a to
d0ef418
Compare
rjl493456442
force-pushed
the
record_write_pause
branch
from
d0ef418 to
e1013ad
Compare
rjl493456442
changed the title
syndtr
requested changes
Dec 13, 2017
|
|
||
| // Stats. | ||
| aliveSnaps, aliveIters int32 | ||
| writeDelayStat *wDelayStat |
Owner
There was a problem hiding this comment.
I think we can just unpack wDelayStat struct into DB struct. Also I think using sync/atomic is enough (yes, inconsistency between counter and timer might happen but I think that's not a big issue in this case), you can cast time.Duration to int64.
syndtr
approved these changes
Dec 13, 2017
syndtr
requested changes
Dec 13, 2017
Owner
syndtr
left a comment
syndtr
left a comment
There was a problem hiding this comment.
I think we can just unpack wDelayStat struct into DB struct. Also I think using sync/atomic is enough (yes, inconsistency between counter and timer might happen but I think that's not a big issue in this case), you can cast time.Duration to int64.
Contributor
Author
|
@syndtr Updated! |
syndtr
added a commit
that referenced
this pull request
Dec 14, 2017
Merge #193, resolve #181. Squashed commit of the following: commit ba80ecc36712f250c44b6c6b0a6f70702fa2f6b0 Author: Suryandaru Triandana <syndtr@gmail.com> Date: Thu Dec 14 19:06:05 2017 +0700 leveld: fix some formatting and make sure 64-bit 'atomic' fields are 64-bit aligned commit 9d05f5b Author: rjl493456442 <garyrong0905@gmail.com> Date: Wed Dec 13 16:27:37 2017 +0800 leveldb: unpack cwriteDelay struct to db commit e1013ad Author: rjl493456442 <garyrong0905@gmail.com> Date: Wed Dec 13 13:34:38 2017 +0800 leveldb: add api for write delay query
Owner
|
Merged at 34011bf. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #181