ethdb: Add paused write stat#15663
Closed
rjl493456442 wants to merge 7 commits into
Closed
Conversation
75d64da to
8978fcb
Compare
Member
Author
|
@karalabe PTAL |
Member
|
Sweet :) A few suggestions:
|
7164449 to
412f09b
Compare
Member
Author
|
Updated. I run go-ethereum with fast sync mode at a clear state and dump write delay information to a file. So i set the write delay number threshold at 200, and write delay duration threshold at 350 milliseconds. If the stats beyond the threshold, a warning log will been printed at user's console. |
karalabe
reviewed
Dec 20, 2017
Member
There was a problem hiding this comment.
Please use 500 * time.Millisecond here.
412f09b to
c3bb251
Compare
16fcb9b to
f2d8d85
Compare
Member
Author
|
Superseded in #16499 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: we need to wait this pr in goleveldb get merged and do the next :)
Implements #15347