symfony/phpunit-bridge: set umask(0000) when debug is true by fancyweb · Pull Request #889 · symfony/recipes

fancyweb · 2021-02-05T13:52:31Z

Q	A
License	MIT
Doc issue/PR	-

When running functional tests with an empty cache (no directory), the cache directory is created. I run my tests with APP_DEBUG=1. I expect the cache directory to be created with the same permissions whether it is created from the tests or from a real request on the front controller. Currently, running the tests and then accessing the application lead to unexpected permissions errors.

Ref #210

ghost

Pull request passes validation.

symfony/phpunit-bridge/3.3/tests/bootstrap.php

ghost

Pull request passes validation.

nicolas-grekas · 2021-07-10T09:10:58Z

(please rebase so that we can run the new checks)

ghost

Pull request passes validation.

github-actions · 2021-07-12T07:24:43Z

Thanks for the PR 😍

How to test these changes in your application

Define the SYMFONY_ENDPOINT environment variable:

# On Unix-like (BSD, Linux and macOS)
export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-889/index.json
# On Windows
SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-889/index.json

Install the package(s) related to this recipe:

composer req 'symfony/flex:^1.16'
composer req 'symfony/phpunit-bridge:^5.3'

Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

# On Unix-like (BSD, Linux and macOS)
unset SYMFONY_ENDPOINT
# On Windows
SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

symfony/phpunit-bridge

3.3 vs 4.1

diff --git a/symfony/phpunit-bridge/3.3/.env.test b/symfony/phpunit-bridge/4.1/.env.test
index 24a43c0..9e7162f 100644
--- a/symfony/phpunit-bridge/3.3/.env.test
+++ b/symfony/phpunit-bridge/4.1/.env.test
@@ -2,3 +2,5 @@
 KERNEL_CLASS='App\Kernel'
 APP_SECRET='$ecretf0rt3st'
 SYMFONY_DEPRECATIONS_HELPER=999999
+PANTHER_APP_ENV=panther
+PANTHER_ERROR_SCREENSHOT_DIR=./var/error-screenshots
diff --git a/symfony/phpunit-bridge/3.3/bin/phpunit b/symfony/phpunit-bridge/4.1/bin/phpunit
index 0b79fd4..63dae24 100755
--- a/symfony/phpunit-bridge/3.3/bin/phpunit
+++ b/symfony/phpunit-bridge/4.1/bin/phpunit
@@ -6,12 +6,6 @@ if (!file_exists(dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-php
     exit(1);
 }
 
-if (false === getenv('SYMFONY_PHPUNIT_VERSION')) {
-    putenv('SYMFONY_PHPUNIT_VERSION=6.5');
-}
-if (false === getenv('SYMFONY_PHPUNIT_REMOVE')) {
-    putenv('SYMFONY_PHPUNIT_REMOVE=symfony/yaml');
-}
 if (false === getenv('SYMFONY_PHPUNIT_DIR')) {
     putenv('SYMFONY_PHPUNIT_DIR='.__DIR__.'/.phpunit');
 }
diff --git a/symfony/phpunit-bridge/3.3/phpunit.xml.dist b/symfony/phpunit-bridge/4.1/phpunit.xml.dist
index 294a559..d81f0c3 100644
--- a/symfony/phpunit-bridge/3.3/phpunit.xml.dist
+++ b/symfony/phpunit-bridge/4.1/phpunit.xml.dist
@@ -8,10 +8,11 @@
          bootstrap="tests/bootstrap.php"
 >
     <php>
-        <ini name="display_errors" value="1" />
         <ini name="error_reporting" value="-1" />
         <server name="APP_ENV" value="test" force="true" />
         <server name="SHELL_VERBOSITY" value="-1" />
+        <server name="SYMFONY_PHPUNIT_REMOVE" value="" />
+        <server name="SYMFONY_PHPUNIT_VERSION" value="7.5" />
     </php>
 
     <testsuites>
@@ -21,8 +22,8 @@
     </testsuites>
 
     <filter>
-        <whitelist>
-            <directory>src</directory>
+        <whitelist processUncoveredFilesFromWhitelist="true">
+            <directory suffix=".php">src</directory>
         </whitelist>
     </filter>

4.1 vs 4.3

diff --git a/symfony/phpunit-bridge/4.1/bin/phpunit b/symfony/phpunit-bridge/4.3/bin/phpunit
index 63dae24..4d1ed05 100755
--- a/symfony/phpunit-bridge/4.1/bin/phpunit
+++ b/symfony/phpunit-bridge/4.3/bin/phpunit
@@ -1,8 +1,8 @@
 #!/usr/bin/env php
 <?php
 
-if (!file_exists(dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-phpunit')) {
-    echo "Unable to find the `simple-phpunit` script in `vendor/symfony/phpunit-bridge/bin/`.\n";
+if (!file_exists(dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-phpunit.php')) {
+    echo "Unable to find the `simple-phpunit.php` script in `vendor/symfony/phpunit-bridge/bin/`.\n";
     exit(1);
 }
 
@@ -10,4 +10,4 @@ if (false === getenv('SYMFONY_PHPUNIT_DIR')) {
     putenv('SYMFONY_PHPUNIT_DIR='.__DIR__.'/.phpunit');
 }
 
-require dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-phpunit';
+require dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-phpunit.php';
diff --git a/symfony/phpunit-bridge/4.1/phpunit.xml.dist b/symfony/phpunit-bridge/4.3/phpunit.xml.dist
index d81f0c3..5766779 100644
--- a/symfony/phpunit-bridge/4.1/phpunit.xml.dist
+++ b/symfony/phpunit-bridge/4.3/phpunit.xml.dist
@@ -8,6 +8,7 @@
          bootstrap="tests/bootstrap.php"
 >
     <php>
+        <ini name="display_errors" value="1" />
         <ini name="error_reporting" value="-1" />
         <server name="APP_ENV" value="test" force="true" />
         <server name="SHELL_VERBOSITY" value="-1" />

4.3 vs 5.1

diff --git a/symfony/phpunit-bridge/4.3/phpunit.xml.dist b/symfony/phpunit-bridge/5.1/phpunit.xml.dist
index 5766779..0bd20c8 100644
--- a/symfony/phpunit-bridge/4.3/phpunit.xml.dist
+++ b/symfony/phpunit-bridge/5.1/phpunit.xml.dist
@@ -8,12 +8,11 @@
          bootstrap="tests/bootstrap.php"
 >
     <php>
-        <ini name="display_errors" value="1" />
         <ini name="error_reporting" value="-1" />
         <server name="APP_ENV" value="test" force="true" />
         <server name="SHELL_VERBOSITY" value="-1" />
         <server name="SYMFONY_PHPUNIT_REMOVE" value="" />
-        <server name="SYMFONY_PHPUNIT_VERSION" value="7.5" />
+        <server name="SYMFONY_PHPUNIT_VERSION" value="8.5" />
     </php>
 
     <testsuites>
@@ -31,4 +30,11 @@
     <listeners>
         <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
     </listeners>
+
+    <!-- Run `composer require symfony/panther` before enabling this extension -->
+    <!--
+    <extensions>
+        <extension class="Symfony\Component\Panther\ServerExtension" />
+    </extensions>
+    -->
 </phpunit>

5.1 vs 5.3

diff --git a/symfony/phpunit-bridge/5.1/bin/phpunit b/symfony/phpunit-bridge/5.3/bin/phpunit
index 4d1ed05..f26f2c7 100755
--- a/symfony/phpunit-bridge/5.1/bin/phpunit
+++ b/symfony/phpunit-bridge/5.3/bin/phpunit
@@ -1,13 +1,19 @@
 #!/usr/bin/env php
 <?php
 
-if (!file_exists(dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-phpunit.php')) {
-    echo "Unable to find the `simple-phpunit.php` script in `vendor/symfony/phpunit-bridge/bin/`.\n";
-    exit(1);
+if (!ini_get('date.timezone')) {
+    ini_set('date.timezone', 'UTC');
 }
 
-if (false === getenv('SYMFONY_PHPUNIT_DIR')) {
-    putenv('SYMFONY_PHPUNIT_DIR='.__DIR__.'/.phpunit');
-}
+if (is_file(dirname(__DIR__).'/vendor/phpunit/phpunit/phpunit')) {
+    define('PHPUNIT_COMPOSER_INSTALL', dirname(__DIR__).'/vendor/autoload.php');
+    require PHPUNIT_COMPOSER_INSTALL;
+    PHPUnit\TextUI\Command::main();
+} else {
+    if (!is_file(dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-phpunit.php')) {
+        echo "Unable to find the `simple-phpunit.php` script in `vendor/symfony/phpunit-bridge/bin/`.\n";
+        exit(1);
+    }
 
-require dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-phpunit.php';
+    require dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-phpunit.php';
+}
diff --git a/symfony/phpunit-bridge/5.1/manifest.json b/symfony/phpunit-bridge/5.3/manifest.json
index a2ed0cb..4fb292b 100644
--- a/symfony/phpunit-bridge/5.1/manifest.json
+++ b/symfony/phpunit-bridge/5.3/manifest.json
@@ -6,7 +6,6 @@
         "tests/": "tests/"
     },
     "gitignore": [
-        ".phpunit",
         ".phpunit.result.cache",
         "/phpunit.xml"
     ],
diff --git a/symfony/phpunit-bridge/5.1/phpunit.xml.dist b/symfony/phpunit-bridge/5.3/phpunit.xml.dist
index 0bd20c8..af3f147 100644
--- a/symfony/phpunit-bridge/5.1/phpunit.xml.dist
+++ b/symfony/phpunit-bridge/5.3/phpunit.xml.dist
@@ -2,17 +2,19 @@
 
 <!-- https://phpunit.readthedocs.io/en/latest/configuration.html -->
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="bin/.phpunit/phpunit.xsd"
+         xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
          backupGlobals="false"
          colors="true"
          bootstrap="tests/bootstrap.php"
+         convertDeprecationsToExceptions="false"
 >
     <php>
+        <ini name="display_errors" value="1" />
         <ini name="error_reporting" value="-1" />
         <server name="APP_ENV" value="test" force="true" />
         <server name="SHELL_VERBOSITY" value="-1" />
         <server name="SYMFONY_PHPUNIT_REMOVE" value="" />
-        <server name="SYMFONY_PHPUNIT_VERSION" value="8.5" />
+        <server name="SYMFONY_PHPUNIT_VERSION" value="9.5" />
     </php>
 
     <testsuites>
@@ -21,11 +23,11 @@
         </testsuite>
     </testsuites>
 
-    <filter>
-        <whitelist processUncoveredFilesFromWhitelist="true">
+    <coverage processUncoveredFiles="true">
+        <include>
             <directory suffix=".php">src</directory>
-        </whitelist>
-    </filter>
+        </include>
+    </coverage>
 
     <listeners>
         <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
diff --git a/symfony/phpunit-bridge/5.1/post-install.txt b/symfony/phpunit-bridge/5.3/post-install.txt
index 2db39ab..e9da2a6 100644
--- a/symfony/phpunit-bridge/5.1/post-install.txt
+++ b/symfony/phpunit-bridge/5.3/post-install.txt
@@ -1,2 +1,3 @@
   * Write test cases in the tests/ folder
-  * Run php bin/phpunit
+  * Use MakerBundle's make:test command as a shortcut!
+  * Run the tests with php bin/phpunit

nicolas-grekas · 2021-07-12T13:27:48Z

This should target the recipe for 5.3 IMHO.

nicolas-grekas · 2021-07-12T13:29:34Z

At least, since we don't use symlinks anymore, this should update the latest of each major.

nicolas-grekas · 2022-02-17T15:45:29Z

Friendly ping @fancyweb

symfony/phpunit-bridge/4.1/tests/bootstrap.php

Applies symfony#889 to the PHPUnit recipe.

…1402) * Make PHPUnit 10 config more consistent with PHPUnitBridge behavior * Set umask(1000) when debug is true Applies #889 to the PHPUnit recipe.

…ymfony#1402) * Make PHPUnit 10 config more consistent with PHPUnitBridge behavior * Set umask(1000) when debug is true Applies symfony#889 to the PHPUnit recipe.

ghost deployed to staging February 5, 2021 13:52 View deployment

ghost approved these changes Feb 5, 2021

View reviewed changes

nicolas-grekas reviewed Feb 5, 2021

View reviewed changes

symfony/phpunit-bridge/3.3/tests/bootstrap.php Outdated Show resolved Hide resolved

fancyweb force-pushed the symfony/phpunit-bridge/umask-debug branch from 565e190 to d2c8786 Compare February 5, 2021 16:14

ghost deployed to staging February 5, 2021 16:14 View deployment

ghost approved these changes Feb 5, 2021

View reviewed changes

nicolas-grekas previously approved these changes Feb 5, 2021

View reviewed changes

nicolas-grekas requested a review from weaverryan March 23, 2021 17:01

nicolas-grekas force-pushed the master branch from 735eca4 to b570dde Compare July 7, 2021 14:11

fancyweb force-pushed the symfony/phpunit-bridge/umask-debug branch from d2c8786 to 5916d06 Compare July 12, 2021 07:24

ghost deployed to staging July 12, 2021 07:24 View deployment

ghost previously approved these changes Jul 12, 2021

View reviewed changes

github-actions bot dismissed nicolas-grekas’s stale review via 5916d06 March 10, 2022 08:58

fancyweb dismissed ghost ’s stale review via 7fa78b1 December 23, 2022 16:14

fancyweb force-pushed the symfony/phpunit-bridge/umask-debug branch from 5916d06 to 7fa78b1 Compare December 23, 2022 16:14

fabpot requested changes Dec 31, 2022

View reviewed changes

symfony/phpunit-bridge/4.1/tests/bootstrap.php Outdated Show resolved Hide resolved

symfony/phpunit-bridge: set umask(0000) when debug is true

57e4d9e

fancyweb force-pushed the symfony/phpunit-bridge/umask-debug branch from 7fa78b1 to 57e4d9e Compare January 2, 2023 08:07

symfony-recipes-bot enabled auto-merge (squash) January 2, 2023 08:07

fabpot approved these changes Jan 2, 2023

View reviewed changes

fabpot disabled auto-merge January 2, 2023 08:28

fabpot merged commit c8cf4a7 into symfony:main Jan 2, 2023

fancyweb deleted the symfony/phpunit-bridge/umask-debug branch January 2, 2023 08:30

wouterj added a commit to wouterj/recipes that referenced this pull request Apr 12, 2025

Set umask(1000) when debug is true

7c91114

Applies symfony#889 to the PHPUnit recipe.

wouterj added a commit to wouterj/recipes that referenced this pull request Apr 12, 2025

Set umask(1000) when debug is true

ae7e228

Applies symfony#889 to the PHPUnit recipe.

wouterj mentioned this pull request Apr 12, 2025

Make PHPUnit 10 config more consistent with PHPUnitBridge behavior #1402

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

symfony/phpunit-bridge: set umask(0000) when debug is true#889

symfony/phpunit-bridge: set umask(0000) when debug is true#889
fabpot merged 1 commit intosymfony:mainfrom
fancyweb:symfony/phpunit-bridge/umask-debug

fancyweb commented Feb 5, 2021

Uh oh!

ghost left a comment

Uh oh!

Uh oh!

ghost left a comment

Uh oh!

nicolas-grekas commented Jul 10, 2021

Uh oh!

ghost left a comment

Uh oh!

github-actions bot commented Jul 12, 2021 •

edited

Loading

Uh oh!

nicolas-grekas commented Jul 12, 2021

Uh oh!

nicolas-grekas commented Jul 12, 2021

Uh oh!

nicolas-grekas commented Feb 17, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

fancyweb commented Feb 5, 2021

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas commented Jul 10, 2021

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to test these changes in your application

Diff between recipe versions

symfony/phpunit-bridge

Uh oh!

nicolas-grekas commented Jul 12, 2021

Uh oh!

nicolas-grekas commented Jul 12, 2021

Uh oh!

nicolas-grekas commented Feb 17, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Jul 12, 2021 •

edited

Loading