Always using umask(0000) in debug mode#210
Merged
symfony-bot merged 2 commits intosymfony:masterfrom Oct 10, 2017
weaverryan:patch-1
Merged
Always using umask(0000) in debug mode#210symfony-bot merged 2 commits intosymfony:masterfrom weaverryan:patch-1
symfony-bot merged 2 commits intosymfony:masterfrom
weaverryan:patch-1
Conversation
symfony-bot
approved these changes
Oct 9, 2017
Contributor
symfony-bot
left a comment
symfony-bot
left a comment
There was a problem hiding this comment.
Pull request passes validation.
symfony-bot
approved these changes
Oct 9, 2017
Contributor
symfony-bot
left a comment
symfony-bot
left a comment
There was a problem hiding this comment.
Pull request passes validation.
symfony-bot
approved these changes
Oct 9, 2017
Contributor
symfony-bot
left a comment
symfony-bot
left a comment
There was a problem hiding this comment.
Pull request passes validation.
symfony-bot
approved these changes
Oct 9, 2017
Contributor
symfony-bot
left a comment
symfony-bot
left a comment
There was a problem hiding this comment.
Pull request passes validation.
fabpot
approved these changes
Oct 10, 2017
stof
approved these changes
Oct 10, 2017
Member
|
@weaverryan the reason there is no class_exists in index.php is because HttpKernel has a requirement on |
nicwortel
added a commit
to nicwortel/symfony-skeleton
that referenced
this pull request
Oct 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In debug mode, cache files need to be writeable by everyone for a good dev experience. In
prod, they do not (and the way the cache system is built these days makes this very easy - yay!).This change is consistent with how
index.phpalready exists: enableumaskfor debug, but not otherwise. This gives great DX for dev, and forces users to setup permissions properly for prod.I've also proposed removing the warning about permissions... basically because if this is for debug mode only, is there really an issue with
umask(0000)? There are many things in debug mode you would not want to do/expose in prod mode (e.g. web debug toolbar). This is just another one of those.P.S. I wasn't sure why there is a
class_exists(Debug::class)inconsole, but not inindex.php, but I left that alone.