Made PHPCR initializer independent, creating all route_basepaths

[pamil]

Related PR Sylius/Sylius#3668.

[pamil]

Failed only on PHP7, may be connected with enabled XDebug on Travis.

[wouterj]

please do not depend on phpunit

[dbu]

thanks!
i restarted the builds that failed. as master is not failing, i think it should work. if it still does not, we can try restarting the build for master to see if with the final release of php 7, there was some change that makes us break.

[pamil]

I disabled XDebug and it passes :)

[pjedrzejewski]

👍

[wouterj]

So there is now a bC break in this PR: While route basepaths were not initialized by default before, they are now. I think we the RoutingBundle should keep using the old configuration and not initialize the basepaths unless configured.

[dbu]

agreed. lets say that initializer defaults to `auto` and auto means if sonata is active, we do the initializer, otherwise not. and if its true/false we just do or not do the initializer.

[dbu]

@pamil can you adjust the PR to use auto for the initializer?

[pamil]

@dbu Sure, thanks for reminding me this PR, I almost forgot about it. I'm on my way! :)

[pamil]

@dbu should be up and running now.

[pamil]

Only StyleCI is failing and it's (mostly) not related to my changes.

[dantleech]

@pamil you should be able to rebase: try (on your branch):

$ git fetch origin
$ git rebase origin/master

If it encounters any conflicts you will need to fix them and then:

$ git add /fixed/files
$ git rebase --continue

If you have any difficulties let us know

[pamil]

@dantleech thanks, I must have missed something, now the rebase went all easy :) Style CI is passing, tests should be passing.

[dbu]

great, this looks good now!
can you please squash the commits into 1 commit plus 1 for the travis config change? (git rebase -i... then reorder the commits and squash the last two into the first one)

[pamil]

@dbu done :)

[dbu]

thanks. one last thing: can you please do a pull request on the symfony-cmf-docs repository to update the configuration references of the routing bundle? i think its enough to mention the feature there. but if you want you can look over the routing documentation and see if there is a place where it would make sense to mention this feature. please use the versionadded functionality (this feature will be in version 1.4)

[dbu]

thanks a lot. created symfony-cmf/symfony-cmf-docs#724 for the documentation.

[pjedrzejewski]

👍