Shutdown uses getTransport() that is Jackalope\Session specific

[pamil]

I'm using my own class that implements PHPCR\SessionInterface and acts as a decorator for another sessions. I don't have getTransport() method implemented, because it's not required by that interface.
https://github.com/doctrine/DoctrinePHPCRBundle/blob/master/DoctrinePHPCRBundle.php#L144

There are two possible solutions to solve this issue:

• check whether session is the Jackalope one
• add getTransport() on PHPCR\SessionInterface (rather not)

[dbu]

yes, lets add an instanceof check for jackalope there. its working around a pecularity of the session.

[dbu]

can you do a pull request please?

[lsmith77]

BTW .. is your own PHPCR implementation open source?

[pamil]

@dbu I will on tommorow's morning :)

@lsmith77 it's a simple decorator that proxies methods to Jackalope\Session, it only juggles between them. As my application is built on top of Sylius that has container-cleaner (rather naive implementation, but reduces memory usage a lot), the connections should be closed automatically in my case.

In the meantime, could you look at symfony-cmf/routing-bundle#318? I suppose it's not the best moment for new PR as code formatting have just been changed there :)

[dbu]

@pamil could the thing your decorator is doing be contributed into jackalope? or is it specific to your project / to sylius? if we can optimize memory usage of jackalope, that would be nice...

[pamil]

@dbu that decorator in fact increases memory usage as it stores another sessions in it, I'm developing a multi-tenant application where every tenant has its own workspace and it allows me to achieve it quite transparently.

As for reducing memory while testing, you may want to take a look at current Sylius' TestKernel - before that we had to run Behat from CLI for almost 20 times and we were still using over 1-2GB in some cases, now we can run whole Behat test suite at once and keep memory usage <500MB. (It was quite simple, as there were some references to container somewhere and it wasn't collected by GC). Unfortunately, I don't think that would apply to Jackalope as it's already quite good.

[dbu]

alright, thanks for the update.