Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create pull request template #4770

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: create pull request template #4770

wants to merge 2 commits into from

Conversation

gfellerph
Copy link
Member

@gfellerph gfellerph commented Feb 24, 2025

📄 Description

This PR adds a pull request template that will be used to prefill the body of each pull request. The goal is to create pull requests that are easier to review because the reviewer gets all the information necessary before digging into the code

🚀 Demo

## 📄 Description

Please include a summary of the changes made in this PR.

## 🚀 Demo

If applicable, please add a screenshot or video to illustrate the changes.

---

## 📝 Checklist

- ✅ My code follows the style guidelines of this project
- 🛠️ I have performed a self-review of my own code
- 📄 I have made corresponding changes to the documentation
- ⚠️ My changes generate no new warnings or errors
- 🧪 I have added tests that prove my fix is effective or that my feature works
- ✔️ New and existing unit tests pass locally with my changes

📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • ✔️ New and existing unit tests pass locally with my changes

@gfellerph gfellerph requested a review from a team as a code owner February 24, 2025 18:41
Copy link

changeset-bot bot commented Feb 24, 2025

⚠️ No Changeset found

Latest commit: d021baf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gfellerph gfellerph added the needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers label Feb 24, 2025
Comment on lines 1 to 4
## 📌 Ticket

Please provide the URL to the Jira ticket related to this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? The ticket is usually available in the right column under "Development":
image

Comment on lines +9 to +12
## 🚀 Demo

If applicable, please add a screenshot or video to illustrate the changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the preview link for that, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but a screenshot or a video really helps to illustrate the change fast so you don't have to go hunt for what could possibly have changed based on the source. I'd like to keep that point.

Copy link

sonarqubecloud bot commented Mar 5, 2025

@gfellerph gfellerph requested a review from alizedebray March 5, 2025 13:16
@gfellerph gfellerph removed the needs: 🏓 dev roundtable To be discussed at the roundtable of esteemed developers label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants