Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(intranet-header-workspace): remove user image logic #4667

Merged
merged 6 commits into from
Feb 27, 2025
Merged

chore(intranet-header-workspace): remove user image logic #4667

merged 6 commits into from
Feb 27, 2025

Conversation

myrta2302
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 9b17ea8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-documentation Patch
@swisspost/design-system-demo Patch
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-tokens Patch
@swisspost/design-system-components Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-icons Patch
@swisspost/design-system-migrations Patch
@swisspost/design-system-styles-primeng Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Feb 13, 2025 •
edited
Loading

Related Previews

@myrta2302 myrta2302 linked an issue Feb 13, 2025 that may be closed by this pull request
Remove the user image logic from the intranet-header component #4609
Open
@myrta2302 myrta2302 marked this pull request as ready for review February 13, 2025 15:18
@myrta2302 myrta2302 requested a review from a team as a code owner February 13, 2025 15:18
@myrta2302 myrta2302 requested a review from leagrdv February 13, 2025 15:18
@myrta2302 myrta2302 requested a review from leagrdv February 14, 2025 08:31
leagrdv
leagrdv reviewed Feb 14, 2025
View reviewed changes
Copy link
Contributor

@leagrdv leagrdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

oliverschuerch
oliverschuerch requested changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@oliverschuerch oliverschuerch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would by nice if we could let users now also on the props table what and why we changed stuff, regarding the user image.

image

@myrta2302 myrta2302 requested a review from leagrdv February 24, 2025 13:16
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@myrta2302 myrta2302 merged commit 19ce22b into release/v8 Feb 27, 2025
11 checks passed
@myrta2302 myrta2302 deleted the chore(intranet-header-workspace)-remove-user-image-logic branch February 27, 2025 07:24
@swisspost-bot swisspost-bot mentioned this pull request Feb 27, 2025
Open
myrta2302 added a commit that referenced this pull request Feb 27, 2025
@myrta2302
chore(intranet-header-workspace): remove user image logic (#4667)
341cc05
myrta2302 added a commit that referenced this pull request Mar 4, 2025
@myrta2302 @alizedebray
chore(intranet-header-workspace): remove user image logic (#4667) (#4821
f74b035 
)

Co-authored-by: Alizé Debray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverschuerch oliverschuerch oliverschuerch approved these changes

@leagrdv leagrdv leagrdv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the user image logic from the intranet-header component
4 participants
@myrta2302 @swisspost-bot @oliverschuerch @leagrdv