-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(popover): stay open on click when using polyfill #3211
fix(popover): stay open on click when using polyfill #3211
Conversation
Firefox ESR does not support the popover attribute and therefore uses the polyfill. Because the popover was nested in a shadow root, the polyfill did not work correctly (see #2925 (comment)). Not using shadow-dom for the post-popovercontainer fixes the issue.
🦋 Changeset detectedLatest commit: 579eb35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Related Previews |
packages/components/src/index.html
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes can be reverted.
|
Firefox ESR does not support the popover attribute and therefore uses the polyfill. Because the popover was nested in a shadow root, the polyfill did not work correctly (see #2925 (comment)). Not using shadow-dom for the post-popovercontainer fixes the issue.