Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add post-button webcomponent #3193

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Meierschlumpf
Copy link

@Meierschlumpf Meierschlumpf commented Jun 27, 2024

image

Copy link

changeset-bot bot commented Jun 27, 2024

⚠️ No Changeset found

Latest commit: 1a8b40f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gfellerph
Copy link
Member

Thanks @Meierschlumpf for the initiative. Please mark the PR as ready for review when you're ready for the first feedback 🤓

@Meierschlumpf
Copy link
Author

I've got two questions regarding the implementation:

  1. How to deal with class names? should we just forward them? (Especially for the full width example)
  2. How do we deal with buttons that are used as a tags or that are using custom components like Link in NextJS? Do we just not support them through this component as for example loading will not be necessary for links?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants