Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): invalid message on card-control #2978

Conversation

davidritter-dotcom
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: 9c095e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@swisspost/design-system-components Minor
@swisspost/design-system-styles Minor
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components-react Minor
@swisspost/design-system-documentation Patch
@swisspost/design-system-components-angular Minor
@swisspost/design-system-demo Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-intranet-header Minor
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-icons Minor
@swisspost/design-system-migrations Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Apr 18, 2024

Preview environment ready: https://preview-2978--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-2978--swisspost-design-system-next.netlify.app

@oliverschuerch
Copy link
Contributor

oliverschuerch commented Apr 19, 2024

There is an open PR for merging the card-control stories. Please do not merge this PR before the other (#2847)!

@oliverschuerch oliverschuerch added the 🚂 PR train PR which follows another one. label Apr 19, 2024
…-only-component

# Conflicts:
#	packages/documentation/src/stories/components/forms/card-control/web-component/card-control.stories.ts
#	packages/documentation/src/stories/components/forms/choice-card/choice-card.ts
@gfellerph gfellerph removed their request for review May 2, 2024 14:10
Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something looks wrong with the icon placement
image

Tested on the css-component (web-component looks good).

Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@davidritter-dotcom
Copy link
Contributor Author

I've only added the icon in the message on the form elements who don't have an icon inside in this PR, but since the icon inside gets removed everywhere, the icon would need to be added everywhere in the validation message.

Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changeset!

packages/styles/src/components/form-validation.scss Outdated Show resolved Hide resolved
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Jun 4, 2024

Related Previews

@swisspost-bot
Copy link
Contributor

Related Previews
Preview URLs will be added here, once they are ready... loader

Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidritter-dotcom did you add the error-message only for the web-component or also for the css-component?
And could we add the error-message also in the default story of both components?

@davidritter-dotcom
Copy link
Contributor Author

davidritter-dotcom commented Jul 3, 2024

I added the icon for all the invalid- and valid-feedback messages of the form elements. The icon inside the input and the textarea gets removed in a separate ticket. #2527

Copy link

sonarcloud bot commented Jul 10, 2024

@davidritter-dotcom davidritter-dotcom merged commit 38a9af3 into main Jul 16, 2024
10 checks passed
@davidritter-dotcom davidritter-dotcom deleted the 2625-create-form-control-invalid-message-css-only-component branch July 16, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚂 PR train PR which follows another one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create form-control-invalid-message CSS-only component
3 participants