-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(styles): invalid message on card-control #2978
feat(styles): invalid message on card-control #2978
Conversation
🦋 Changeset detectedLatest commit: 9c095e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Preview environment ready: https://preview-2978--swisspost-web-frontend.netlify.app |
There is an open PR for merging the card-control stories. Please do not merge this PR before the other (#2847)! |
…-only-component # Conflicts: # packages/documentation/src/stories/components/forms/card-control/web-component/card-control.stories.ts # packages/documentation/src/stories/components/forms/choice-card/choice-card.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I've only added the icon in the message on the form elements who don't have an icon inside in this PR, but since the icon inside gets removed everywhere, the icon would need to be added everywhere in the validation message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changeset!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidritter-dotcom did you add the error-message only for the web-component or also for the css-component?
And could we add the error-message also in the default story of both components?
I added the icon for all the invalid- and valid-feedback messages of the form elements. The icon inside the input and the textarea gets removed in a separate ticket. #2527 |
|
No description provided.