[SE-0481] Allow weak let and make weak captures immutable #80440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickolas-pohilets
requested review from
DougGregor,
hborla,
slavapestov and
xedin
as code owners
nickolas-pohilets
force-pushed
the
mpokhylets/weak-let
branch
from
67d465f to
b1ba6f3
Compare
nickolas-pohilets
requested review from
a team,
adrian-prantl,
jckarter and
ktoso
as code owners
nickolas-pohilets
force-pushed
the
mpokhylets/weak-let
branch
from
b1ba6f3 to
83a0a48
Compare
nickolas-pohilets
force-pushed
the
mpokhylets/weak-let
branch
from
83a0a48 to
f10e0a6
Compare
Contributor
|
@swift-ci Please build toolchain |
Contributor
|
@swift-ci Please build macOS toolchain |
nickolas-pohilets
force-pushed
the
mpokhylets/weak-let
branch
from
3b38a25 to
3e0de86
Compare
Contributor
Author
|
@swift-ci Please smoke test |
Remaining failures: DebugInfo/guard-let-scope4.swift expr/closure/closures.swift SILGen/capture-transitive.swift SILGen/dynamic_self.swift SILGen/unowned-class-bound-generic-parameter.swift
nickolas-pohilets
requested review from
ahoppen,
bnbarham and
eeckstein
as code owners
nickolas-pohilets
requested review from
CodaFi,
hamishknight and
rintaro
as code owners
…le weak capture (minor source-breaking change)
Remaining failures: SILGen/unowned-class-bound-generic-parameter.swift
Contributor
Author
|
@swift-ci Please clean smoke test macOS platform |
Contributor
Author
|
@swift-ci Please smoke test Linux platform |
Contributor
Author
|
@swift-ci Please smoke test Windows platform |
Contributor
Author
|
@swift-ci Please test macOS platform |
Contributor
Author
|
@swift-ci Please smoke test macOS platform |
1 similar comment
Contributor
Author
|
@swift-ci Please smoke test macOS platform |
Contributor
Author
|
@swift-ci Please smoke test Windows platform |
Contributor
Author
|
Tests fail on Windows in fails because some of the error messages differ in diagnostic spelling |
Contributor
Author
|
@swift-ci Please smoke test |
nickolas-pohilets
changed the title
hamishknight
approved these changes
May 29, 2025
Contributor
hamishknight
left a comment
hamishknight
left a comment
There was a problem hiding this comment.
Implicit self diagnostic changes LGTM!
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please smoke test macOS platform |
Collaborator
|
@nickolas-pohilets Please refrain from merging PRs containing merge commits. They unnecessarily convolute the history and — as you may have discovered — make it considerably more painful to move changes across branches. |
nickolas-pohilets
added a commit
to nickolas-pohilets/swift
that referenced
this pull request
Aug 22, 2025
…re semantics still wrapped into a feature See swiftlang#80440 and swiftlang#82732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes were originally wrapped into experimental feature, but after proposal was approved, feature was removed and PR applies changes unconditionally.