[Refactoring] Fix a crasher in AddEquatableContext#32435
Merged
theblixguy merged 1 commit intoswiftlang:masterfrom Jun 17, 2020
theblixguy:fix/SR-13000
Merged
[Refactoring] Fix a crasher in AddEquatableContext#32435theblixguy merged 1 commit intoswiftlang:masterfrom theblixguy:fix/SR-13000
theblixguy merged 1 commit intoswiftlang:masterfrom
theblixguy:fix/SR-13000
Conversation
…here is an extended nominal declaration
Collaborator
Author
|
@swift-ci please smoke test |
nathawes
approved these changes
Jun 17, 2020
Contributor
nathawes
left a comment
nathawes
left a comment
There was a problem hiding this comment.
LGTM – thanks for the fix!
Collaborator
Author
|
Windows failure is unrelated (failing test is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When computing available refactoring kinds, we should only create
AddEquatableContextfor an extension if it extends a nominal type.Resolves SR-13000
Resolves rdar://problem/64316798