Fix coverage test on Windows#32434
Merged
compnerd merged 3 commits intoswiftlang:masterfrom Jun 17, 2020
Merged
Conversation
Relying on $PWD made this invalid on Windows
Member
|
@swift-ci please test Windows platform |
compnerd
approved these changes
Jun 17, 2020
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
This seems good to repair the build. Do you think that you could do a follow up change to use something other than foo, bar, baz (outer, middle, inner or something else a bit more meaningful would be great).
Member
|
@swift-ci please smoke test macOS platform |
Member
|
@swift-ci please smoke test Linux platform |
Member
Author
|
Yea sure I can clean that up |
Member
Author
|
Here's the follow up! #32443 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relying on $PWD made this invalid on Windows