Cherry-pick Fix --quiet option not working with swift run #8844 (#8858) #8907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng#8858) Fixes an issue where the `--quiet` option had no effect when used with `swift run` and `swift build` command. ### Motivation: When using the `--quiet` option with `swift run` only error messages should be logged. ### Modifications: - Add `isQuiet` property to filter out messages based on the log level during build phases of the `native`, `xcode` and `swiftbuild` build system. - Remove duplicated declaration of the isVerbose property from different targets. ### Result: When the `--quiet` option is used with the `swift run` and `swift build` command only error messages are logged.
dschaefer2
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
jakepetroules,
owenv,
plemarquand and
shawnhyam
as code owners
jakepetroules
approved these changes
Jul 8, 2025
Member
Author
|
Hmm, tests failing on Linux. I'll double check. |
Not sure why. Passing on main, but not in 6.2.
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please test windows |
Contributor
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #8858 to 6.2.
Fixes an issue where the --quiet option had no effect when used with swift run and swift build command.
Motivation:
When using the --quiet option with swift run only error messages should be logged.
Modifications:
Add isQuiet property to filter out messages based on the log level during build phases of the native, xcode and swiftbuild build system.
Remove duplicated declaration of the isVerbose property from different targets.
Result:
When the --quiet option is used with the swift run and swift build command only error messages are logged.