Skip to content

Streamline file descriptor handling during spawning #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Streamline file descriptor handling during spawning #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a79d425
Expose more file descriptor traits
vlm Oct 31, 2019
b2e4d0b
Streamline file descriptor handling during spawning.
vlm Oct 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions include/llbuild/Basic/PlatformUtility.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ template <typename = FD> struct FileDescriptorTraits;

#if defined(_WIN32)
template <> struct FileDescriptorTraits<HANDLE> {
typedef HANDLE DescriptorType;
static bool IsValid(HANDLE hFile) { return hFile != INVALID_HANDLE_VALUE; }
static void Close(HANDLE hFile) { CloseHandle(hFile); }
static int Read(HANDLE hFile, void *destinationBuffer,
Expand All @@ -85,6 +86,8 @@ template <> struct FileDescriptorTraits<HANDLE> {
};
#endif
template <> struct FileDescriptorTraits<int> {
typedef int DescriptorType;
static const int InvalidDescriptor = -1;
static bool IsValid(int fd) { return fd >= 0; }
static void Close(int fd) { close(fd); }
static int Read(int hFile, void *destinationBuffer,
Expand Down
Loading