Streamline file descriptor handling during spawning #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Leak of the output pipe file descriptors if control pipe can't be opened. * Leak of posix file actions memory if the control pipes can't be created. * Descriptors leak of unrelated tasks into spawned task (linux, win). * Windows code improperly inheriting the control file descriptors. * A race condition in the control channel parsing on windows resulting in a potential double-free. rdar://56800263
|
@swift-ci please smoke test |
vlm
commented
Oct 31, 2019
|
|
||
| // Close the child ends of the forwarded output and control pipes. | ||
| controlPipeChildEnd.close(); | ||
| outputPipeChildEnd.close(); |
There was a problem hiding this comment.
The child ends should be closed under the lock because they are potentially inheritable by other processes if we are to spawn one in a parallel thread.
vlm
commented
Oct 31, 2019
| std::shared_ptr<ManagedDescriptor> outputFdShared | ||
| = std::make_shared<ManagedDescriptor>(std::move(outputPipeParentEnd)); | ||
| std::shared_ptr<ManagedDescriptor> controlFdShared | ||
| = std::make_shared<ManagedDescriptor>(std::move(controlPipeParentEnd)); |
There was a problem hiding this comment.
The shared_ptrs are necessary because we disabled the copy constructor on a ManagedDescriptor, which makes it impossible to copy lambdas around, which makes it impossible to capture it in a lambda with a purpose of forwarding it further.
|
@gmittert if you have a chance to check the windows portion that'd be great! |
|
@vlm Sure! Might take me a bit though, I'm out of office this week. |
dmbryson
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://56800263