Revert support for module-relative documentation extension links (#574) #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
d-ronnqvist
commented
Apr 28, 2023
•
d-ronnqvist
commented
- Explanation: Revert the support for resolving documentation extensions links relative to modules since it caused a regression when a module and a top-level symbol had the same name.features to work in documentation extension title links.
- Scope: Regression with matching documentation extension files with symbols.
- Issue: rdar://108666088
- Risk: Low.
- Testing: Manually verified that reverting this change fixes the regression. Existing automated tests continue to pass.
- Original PR: Revert support for module-relative documentation extension links (#574) #575
- Reviewers: @QuietMisdreavus and @ethan-kusters
|
@swift-ci please test |
d-ronnqvist
deleted the
revert-module-relative-documentation-extension-links-5.9
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.