Revert support for module-relative documentation extension links #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://108666088
|
@swift-ci please test |
QuietMisdreavus
approved these changes
Apr 28, 2023
|
Should we do a true revert here to be safe? Or are you confident the more isolated change will still fix any issues? |
I'm pretty confident in that this fixes the issue. The regression is specific to modules that have a top-level symbol with the same name. I have a project that reproduced the regression that works after these changes. If possible I would like to avoid reverting the entire merge since the same PR also fixed #561 and #560. |
ethan-kusters
approved these changes
Apr 28, 2023
d-ronnqvist
deleted the
revert-module-relative-documentation-extension-links
branch
d-ronnqvist
added a commit
to d-ronnqvist/swift-docc
that referenced
this pull request
Apr 28, 2023
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://108666088
Summary
This reverts the support for resolving documentation extensions links relative to modules since it caused a regression when a module and a top-level symbol had the same name.
Dependencies
None.
Testing
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
[ ] Added tests./bin/testscript and it succeeded[ ] Updated documentation if necessary