Skip to content

Conversation

@QuietMisdreavus
Copy link
Contributor

  • Explanation: Updates diagnostic solution ranges when a given disambiguation is insufficient to point to a single symbol.
  • Scope: Prevents diagnostics from being given with wrong/invalid ranges, including negative column indices.
  • Issues: rdar://150207195
  • Original PRs: use found disambiguation to calculate diagnostic range if present #1213
  • Risk: Low. The change is limited to diagnostic reporting code and shouldn't cause new errors in documentation processing. A new assertion is added but toolchain distributions of Swift-DocC turn assertions off so it shouldn't cause a problem for production uses.
  • Testing: An automated test was added, and manual testing proved the change works with a larger set of triggering cases.
  • Reviewers: @d-ronnqvist

@QuietMisdreavus QuietMisdreavus changed the title use found disambiguation to calculate diagnostic range if present [6.2] use found disambiguation to calculate diagnostic range if present May 9, 2025
@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus QuietMisdreavus requested a review from Teapane May 9, 2025 16:09
@sofiaromorales
Copy link
Contributor

@swift-ci please test

@QuietMisdreavus QuietMisdreavus merged commit 22f3d61 into swiftlang:release/6.2 May 9, 2025
2 checks passed
@QuietMisdreavus QuietMisdreavus deleted the 6.2/collision-range-adjustment branch May 9, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants