Resolves error in prior logic #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overlay imports don't accurately describe the graph name they're modifying in the graph, so when ever we have bystanders, we need to use the parsing of the URL name for the relevant module being extended. This PR updates the prior logic and fixes the test that incorrectly asserting that [email protected] were symbols that extended the "A" module, when the extend the "B" module.
Summary
In the prior logic, incorrectly ported from the shadowed logic in DocC, the symbol graphs were trusted to correctly report the module they extend as the "name" of the module. But in the case of one side of overlay
imports, that isn't correct. This updates the logic, and the incorrect test assertion, to reflect that symbols
in the graph named
[email protected]extend the moduleB, not moduleA, which is in thenameproperty of the graph itself, withBas a bystander.Dependencies
none
Testing
Included unit test illustrates the issue
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded