Skip to content

Conversation

@heckj
Copy link
Member

@heckj heckj commented Sep 3, 2025

Overlay imports don't accurately describe the graph name they're modifying in the graph, so when ever we have bystanders, we need to use the parsing of the URL name for the relevant module being extended. This PR updates the prior logic and fixes the test that incorrectly asserting that [email protected] were symbols that extended the "A" module, when the extend the "B" module.

Summary

In the prior logic, incorrectly ported from the shadowed logic in DocC, the symbol graphs were trusted to correctly report the module they extend as the "name" of the module. But in the case of one side of overlay
imports, that isn't correct. This updates the logic, and the incorrect test assertion, to reflect that symbols
in the graph named [email protected] extend the module B, not module A , which is in the name property of the graph itself, with B as a bystander.

Dependencies

none

Testing

Included unit test illustrates the issue

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran the ./bin/test script and it succeeded

Overlay imports don't accurately describe the graph name they're modifying _in_ the graph,
so when ever we have bystanders, we need to use the parsing of the URL name for the relevant
module being extended. This PR updates the prior logic and fixes the test that incorrectly
asserting that [email protected] were symbols that extended the "A" module, when the extend the
"B" module.
@heckj heckj self-assigned this Sep 3, 2025
@heckj heckj added the bug Something isn't working label Sep 3, 2025
@heckj
Copy link
Member Author

heckj commented Sep 3, 2025

@swift-ci please test

Copy link
Contributor

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

@QuietMisdreavus QuietMisdreavus merged commit 3fc0c68 into swiftlang:main Sep 3, 2025
2 checks passed
@QuietMisdreavus
Copy link
Contributor

I went ahead and merged this to try to unblock CI for the toolchain.

@heckj heckj deleted the overlay-fix branch September 3, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants