Skip to content

Conversation

@heckj
Copy link
Member

@heckj heckj commented Aug 25, 2025

Follow up from https://github.com/swiftlang/swift-docc/pull/1091/files#r2298429213 to address missing logic to accommodate a symbol graph from a cross-import overlay. The additional logic isn't yet matched with tests that verify the results in a loading scenario

@heckj heckj self-assigned this Aug 25, 2025
@heckj
Copy link
Member Author

heckj commented Aug 25, 2025

@swift-ci please test

Copy link
Contributor

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@heckj
Copy link
Member Author

heckj commented Aug 28, 2025

@swift-ci please test

@heckj heckj merged commit 1990702 into swiftlang:main Aug 28, 2025
2 checks passed
@heckj heckj deleted the cross-import-overlay-bystander-logic branch August 28, 2025 18:52
@shahmishal
Copy link
Member

@heckj we are seeing a test failure, however not sure if its relates to this change.

16:43:16  Test Case '-[SwiftDocCTests.RenderMetadataTests testRendersBystanderExtensionsFromSymbolGraph]' started.
16:43:16  /Users/ec2-user/jenkins/workspace/oss-swift-pr-test-macos-arm64/swift-docc/Tests/SwiftDocCTests/Rendering/RenderMetadataTests.swift:131: error: -[SwiftDocCTests.RenderMetadataTests testRendersBystanderExtensionsFromSymbolGraph] : XCTUnwrap failed: expected non-nil value of type "DocumentationNode"
16:43:16  Test Case '-[SwiftDocCTests.RenderMetadataTests testRendersBystanderExtensionsFromSymbolGraph]' failed (0.844 seconds).
16:43:16  Test Suite 'RenderMetadataTests' failed at 2025-08-28 23:43:05.027

https://ci.swift.org/view/Apple%20Silicon%20(main)/job/oss-swift-pr-test-macos-arm64/128/console

@heckj
Copy link
Member Author

heckj commented Sep 2, 2025

I've reproduced the error locally, working to debug and understand how this is impacting the loading in the DocC tests, and making sure that SymbolKit's loader is correctly aligned here.

@heckj
Copy link
Member Author

heckj commented Sep 3, 2025

fixes for the logic that resolve the DocC tests: #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants