Don't just import locale_h.
#775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On modularised platforms, swift-server#771 broke things because it changed from importing `Musl` or `Glibc` to importing just `locale_h`. The latter understandably doesn't define `errno` or `EOVERFLOW`, so we get a build failure. Fixes swift-server#773.
Lukasa
added
the
semver/patch
Lukasa
approved these changes
Sep 30, 2024
|
@swift-server-bot add to allowlist |
|
Thanks @al45tair, much appreciated! ✨ |
| #elseif canImport(Darwin) | ||
| #endif | ||
|
|
||
| #if canImport(Darwin) |
There was a problem hiding this comment.
IMO it would be better to import the other base modules we need like errno_h. Darwin in particular is very heavyweight, and if we can avoid it that would be best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On modularised platforms, #771 broke things because it changed from importing
MuslorGlibcto importing justlocale_h. The latter understandably doesn't defineerrnoorEOVERFLOW, so we get a build failure.Fixes #773.