Explicitly import locale modules #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Darwin module is slowly being split up, and as it gets further along, it will stop importing some of the split-out modules like the one for locale.h that provides newlocale() and other locale API. However, there's a wrinkle that on platforms with xlocale, it's xlocale.h that provides most of the POSIX locale.h functions and not locale.h, so prefer the xlocale module when available.
|
@swift-server-bot add to allowlist |
Lukasa
approved these changes
Sep 14, 2024
Lukasa
added
the
semver/patch
|
This has broken AHC on the Static SDK for Linux and also I believe on Android? (@finagolfin?), because the file in question was using more than just |
al45tair
added a commit
to al45tair/async-http-client
that referenced
this pull request
Sep 30, 2024
On modularised platforms, swift-server#771 broke things because it changed from importing `Musl` or `Glibc` to importing just `locale_h`. The latter understandably doesn't define `errno` or `EOVERFLOW`, so we get a build failure. Fixes swift-server#773.
Lukasa
pushed a commit
that referenced
this pull request
Sep 30, 2024
No, I have never built this repo. I was speaking generally of the many other Swift repos where I had to start adding new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Darwin module is slowly being split up, and as it gets further along, it will stop importing some of the split-out modules like the one for locale.h that provides newlocale() and other locale API. However, there's a wrinkle that on platforms with xlocale, it's xlocale.h that provides most of the POSIX locale.h functions and not locale.h, so prefer the xlocale module when available.