Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address flakiness of testSSLHandshakeErrorPropagation #335

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Address flakiness of testSSLHandshakeErrorPropagation #335

merged 2 commits into from
Jan 25, 2021

Commits on Jan 25, 2021

  1. Address flakiness of testSSLHandshakeErrorPropagation 

    Motivation:

Flaky tests are bad.

This test is flaky because the server closes the connection immediately
upon channelActive. In practice this can mean that the handshake never
even gets a chance to start: by the time the SSLHandler ends up
in the pipeline the connection is already dead. Heck, by the time we
attempt to complete the connection the connection might be dead.

Modifications:

- Change the shutdown to be on first read.
- Remove the disabled autoRead.
- Change the expected NIOTS failure mode to connectTimeout,
    which is how this manifests in NIOTS.

Result:

Test is no longer flaky.
    @Lukasa
    Lukasa committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    e22d958 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into cb-flaky-tests

    @Lukasa
    Lukasa authored Jan 25, 2021
    Configuration menu
    Copy the full SHA
    6f3fa0c View commit details
    Browse the repository at this point in the history