Address flakiness of testSSLHandshakeErrorPropagation #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
added
the
semver/patch
Lukasa
force-pushed
the
cb-flaky-tests
branch
from
70af540
to
4f63e8e
Compare
artemredkin
approved these changes
Jan 22, 2021
Lukasa
force-pushed
the
cb-flaky-tests
branch
from
4f63e8e
to
f121ddf
Compare
|
Oh hey, fun, a new flaky test! Tracking in #290. |
|
@swift-server-bot test this please |
|
@weissi please re-review, I added a new test. |
weissi
approved these changes
Jan 25, 2021
| if isTestingNIOTS() { | ||
| XCTAssertEqual(error as? ChannelError, .connectTimeout(.milliseconds(100))) | ||
| } else { | ||
| XCTAssertEqual((error as? IOError).map { $0.errnoCode }, 54) |
There was a problem hiding this comment.
any reason to use 54 over ECONNRESET?
There was a problem hiding this comment.
I just cribbed it from the test above, happy to swap it.
Motivation:
Flaky tests are bad.
This test is flaky because the server closes the connection immediately
upon channelActive. In practice this can mean that the handshake never
even gets a chance to start: by the time the SSLHandler ends up
in the pipeline the connection is already dead. Heck, by the time we
attempt to complete the connection the connection might be dead.
Modifications:
- Change the shutdown to be on first read.
- Remove the disabled autoRead.
- Change the expected NIOTS failure mode to connectTimeout,
which is how this manifests in NIOTS.
Result:
Test is no longer flaky.
Lukasa
force-pushed
the
cb-flaky-tests
branch
from
6aef0d0
to
e22d958
Compare
|
@swift-server-bot test this please |
|
One good validation of this having fixed a flaky test is that while we've hit at least two other flaky tests, we've not hit the one this was trying to fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Flaky tests are bad.
This test is flaky because the server closes the connection immediately
upon channelActive. In practice this can mean that the handshake never
even gets a chance to start: by the time the SSLHandler ends up
in the pipeline the connection is already dead. Heck, by the time we
attempt to complete the connection the connection might be dead.
Modifications:
which is how this manifests in NIOTS.
Result:
Test is no longer flaky.