Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow empty value cookies #208

Merged
merged 3 commits into from
May 13, 2020
Merged

Conversation

artemredkin
Copy link
Collaborator

Allow empty-value cookies, closes #206

Motivation:
RFC allows empty-value cookies, so we should handle them as well

Modifications:

  1. Fix split in cookie parsing
  2. Add a test

Result:
We can now allow empty value cookies

@artemredkin artemredkin requested review from weissi and Lukasa May 12, 2020 19:47
@artemredkin
Copy link
Collaborator Author

@swift-server-bot test this please

2 similar comments
@artemredkin
Copy link
Collaborator Author

@swift-server-bot test this please

@artemredkin
Copy link
Collaborator Author

@swift-server-bot test this please

Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, thank you!

@artemredkin artemredkin merged commit 75a0433 into master May 13, 2020
@artemredkin artemredkin deleted the fix_empty_value_cookie_parsing branch May 13, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty cookie values are not parsed
3 participants