We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The empty cookie value makes cookie unparsable, which precludes deleting values:
https://github.com/swift-server/async-http-client/blob/master/Sources/AsyncHTTPClient/HTTPClient%2BHTTPCookie.swift#L53
E.g. the Set-Cookie: cookieValue=; Path=/ won't be recognized as a valid HTTPClient.Cookie structure.
Set-Cookie: cookieValue=; Path=/
HTTPClient.Cookie
This violates https://tools.ietf.org/html/rfc6265#section-4.1.1 which requires empty cookies to be parsable.
One fix would be just to add a omittingEmptySubsequences: true to the split() call.
omittingEmptySubsequences: true
The text was updated successfully, but these errors were encountered:
artemredkin
Successfully merging a pull request may close this issue.
The empty cookie value makes cookie unparsable, which precludes deleting values:
https://github.com/swift-server/async-http-client/blob/master/Sources/AsyncHTTPClient/HTTPClient%2BHTTPCookie.swift#L53
E.g. the
Set-Cookie: cookieValue=; Path=/
won't be recognized as a validHTTPClient.Cookie
structure.This violates https://tools.ietf.org/html/rfc6265#section-4.1.1 which requires empty cookies to be parsable.
One fix would be just to add a
omittingEmptySubsequences: true
to the split() call.The text was updated successfully, but these errors were encountered: