Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es/minifier): Support preserve_annotations of terser #9775

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Dec 2, 2024

Description:

  • jsc.output.preserveAnnotations (transform()/.swcrc)
  • format.preserve_annotations (minify())

are added to support stripping out PURE comments while preserving license comments.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Dec 2, 2024
@kdy1 kdy1 requested review from a team as code owners December 2, 2024 01:54
Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: dd17a6c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 2, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 2, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 2, 2024
@kdy1 kdy1 enabled auto-merge (squash) December 2, 2024 02:11
@kdy1 kdy1 disabled auto-merge December 2, 2024 02:51
@kdy1 kdy1 merged commit 6e1c9fd into swc-project:main Dec 2, 2024
150 of 151 checks passed
@kdy1 kdy1 deleted the issue-9674 branch December 2, 2024 03:22
Copy link

codspeed-hq bot commented Dec 2, 2024

CodSpeed Performance Report

Merging #9775 will degrade performances by 4.15%

Comparing kdy1:issue-9674 (692697f) with main (0adad25)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 191 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:issue-9674 Change
serialization of serde 2.7 µs 2.8 µs -4.15%
es/visitor/base-perf/boxing_boxed 3.3 µs 3.2 µs +3.64%
es/visitor/base-perf/boxing_unboxed_clone 2.7 µs 2.6 µs +3.35%

@kdy1 kdy1 modified the milestones: Planned, v1.10.0 Dec 2, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant