Skip to content

Comments

[DONT MERGE] dragonbox for codespeed#11413

Closed
magic-akari wants to merge 3 commits intoswc-project:mainfrom
magic-akari:perf/dragonbox-codespeed
Closed

[DONT MERGE] dragonbox for codespeed#11413
magic-akari wants to merge 3 commits intoswc-project:mainfrom
magic-akari:perf/dragonbox-codespeed

Conversation

@magic-akari
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

@changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2026

⚠️ No Changeset found

Latest commit: 2131961

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security
Copy link

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm js-beautify is 100.0% likely obfuscated

Confidence: 1.00

Location: Package overview

From: package.jsonnpm/js-beautify@1.14.7

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/js-beautify@1.14.7. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

Binary Sizes

File Size
swc.linux-x64-gnu.node 28M (28536008 bytes)

Commit: 22fb5d7

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 2, 2026

CodSpeed Performance Report

Merging #11413 will not alter performance

Comparing magic-akari:perf/dragonbox-codespeed (2131961) with main (147df2f)

Summary

✅ 138 untouched

@magic-akari
Copy link
Member Author

Still no measurable performance improvement with dragonbox v0.0.5. CC @kdy1

@kdy1
Copy link
Member

kdy1 commented Jan 2, 2026

Then I think it might be CPU-specific (if oxc uses a different CPU than the default GHA one) or specific to memory access pattern of oxc. Do you think we should still merge it?

@magic-akari
Copy link
Member Author

I do lean toward migrating to dragonbox. Dragonbox is generally considered faster than Ryu and produces smaller code and lookup tables. As a result, it has been gradually replacing Ryu in newer C++ standard library implementations (e.g., the Microsoft STL) as well as in high-performance libraries such as {fmt}.

@magic-akari magic-akari closed this Jan 2, 2026
@magic-akari magic-akari deleted the perf/dragonbox-codespeed branch January 2, 2026 03:24
@kdy1 kdy1 added this to the Planned milestone Jan 7, 2026
@kdy1 kdy1 modified the milestones: Planned, 1.15.10 Jan 20, 2026
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants