perf(es/lexer): Remove unnecessary check when reading keywords #10866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CodSpeed Performance ReportMerging #10866 will not alter performanceComparing Summary
|
Member
|
Oh sorry I thought this PR was ready for a review |
Member
Author
That's fine. I decide to clean up the code with some other refactor in another pr |
kdy1
approved these changes
Jul 16, 2025
kdy1
pushed a commit
that referenced
this pull request
Jul 17, 2025
**Description:** When handling keywords, we can make sure that the first byte is a valid ASCII character. I will clean up the code if it's worth it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When handling keywords, we can make sure that the first byte is a valid ASCII.
I will clean up the code if it's worth