Skip to content

Conversation

@magic-akari
Copy link
Member

@magic-akari magic-akari commented Jun 24, 2025

@changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2025

⚠️ No Changeset found

Latest commit: b11cb3d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 24, 2025

CodSpeed Performance Report

Merging #10691 will not alter performance

Comparing magic-akari:refactor/jsx-types (b11cb3d) with dev (8a2ac38)

Summary

✅ 140 untouched benchmarks

@magic-akari magic-akari marked this pull request as ready for review June 24, 2025 08:16
@magic-akari magic-akari requested review from a team as code owners June 24, 2025 08:16
* Effective only if `syntax` supports.
*/
react?: ReactConfig;
react?: JSXPreset | ReactConfig;
Copy link
Member Author

@magic-akari magic-akari Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The react field now supports both object-style configuration (maintaining Babel compatibility) and string-based presets (like TypeScript's JSX presets).
However, the current config "react": "react" appears slightly odd. I propose renaming this field to jsx during future configuration refinements.

@kdy1 kdy1 added this to the Planned milestone Jun 24, 2025
@kdy1 kdy1 merged commit 4dfb819 into swc-project:dev Jun 24, 2025
168 checks passed
@kdy1 kdy1 modified the milestones: Planned, v2 (API cleanup) Jun 24, 2025
@magic-akari magic-akari deleted the refactor/jsx-types branch June 25, 2025 05:43
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants