Skip to content

perf(es): Reduce binary size #10416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

perf(es): Reduce binary size #10416

wants to merge 5 commits into from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Apr 29, 2025

Description:

Remove some logic duplication.

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Apr 29, 2025
@kdy1 kdy1 self-assigned this Apr 29, 2025
Copy link

changeset-bot bot commented Apr 29, 2025

⚠️ No Changeset found

Latest commit: c4af1d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codspeed-hq bot commented Apr 29, 2025

CodSpeed Performance Report

Merging #10416 will degrade performances by 2.14%

Comparing kdy1/size (c4af1d0) with main (1c6f65c)

Summary

❌ 1 regressions
✅ 1 untouched benchmarks
⁉️ 150 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
serialization of serde 2.7 µs 2.7 µs -2.14%
⁉️ css/visitor/compare/clone 5.1 ms N/A N/A
⁉️ css/visitor/compare/fold_span 6 ms N/A N/A
⁉️ css/visitor/compare/fold_span_panic 6 ms N/A N/A
⁉️ css/visitor/compare/visit_mut_span 5.4 ms N/A N/A
⁉️ css/visitor/compare/visit_mut_span_panic 5.4 ms N/A N/A
⁉️ css/lexer/bootstrap_5_1_3 10.3 ms N/A N/A
⁉️ css/lexer/foundation_6_7_4 8.3 ms N/A N/A
⁉️ css/lexer/tailwind_3_1_1 1.6 ms N/A N/A
⁉️ css/parser/bootstrap_5_1_3 47.4 ms N/A N/A
⁉️ css/parser/foundation_6_7_4 37.5 ms N/A N/A
⁉️ css/parser/tailwind_3_1_1 7.3 ms N/A N/A
⁉️ es/codegen/colors 68.7 µs N/A N/A
⁉️ es/codegen/large 657.6 µs N/A N/A
⁉️ es/codegen/with-parser/colors 188.3 µs N/A N/A
⁉️ es/codegen/with-parser/large 1.4 ms N/A N/A
⁉️ es/fast-lexer/angular 9.2 ms N/A N/A
⁉️ es/fast-lexer/backbone 1.2 ms N/A N/A
⁉️ es/fast-lexer/jquery 6.1 ms N/A N/A
⁉️ es/fast-lexer/jquery mobile 10 ms N/A N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant