refactor: Use debug level tracing for ast related tracing#10411
Merged
kdy1 merged 3 commits intoswc-project:mainfrom Apr 29, 2025
Merged
refactor: Use debug level tracing for ast related tracing#10411kdy1 merged 3 commits intoswc-project:mainfrom
kdy1 merged 3 commits intoswc-project:mainfrom
Conversation
🦋 Changeset detectedLatest commit: c262238 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hardfist
force-pushed
the
yj/use-debug-tracing
branch
from
ac5dcfc to
9a14cac
Compare
CodSpeed Performance ReportMerging #10411 will degrade performances by 2.51%Comparing Summary
Benchmarks breakdown
|
kdy1
reviewed
Apr 29, 2025
Member
kdy1
left a comment
kdy1
left a comment
There was a problem hiding this comment.
Can you modify swc_trace_macro, too?
Collaborator
Author
done |
hardfist
force-pushed
the
yj/use-debug-tracing
branch
from
dab45d9 to
617278f
Compare
kdy1
changed the title
kdy1
approved these changes
Apr 29, 2025
bvanjoi
pushed a commit
to bvanjoi/swc
that referenced
this pull request
Apr 29, 2025
…t#10411) **Description:** ast related tracing contains too much trace data and seems not suitable for info level tracing, so change it to debug level which is same as rustc https://github.com/rust-lang/rust/blob/2ea33b591050c4ca1a3752830b29112638faecf6/compiler/rustc_ast_lowering/src/index.rs#L74
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
ast related tracing contains too much trace data and seems not suitable for info level tracing, so change it to debug level which is same as rustc https://github.com/rust-lang/rust/blob/2ea33b591050c4ca1a3752830b29112638faecf6/compiler/rustc_ast_lowering/src/index.rs#L74
BREAKING CHANGE:
No
Related issue (if exists):