Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Fix insufficient logging #10091

Merged
merged 3 commits into from
Feb 25, 2025
Merged

fix(es/minifier): Fix insufficient logging #10091

merged 3 commits into from
Feb 25, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 25, 2025

Description:

This PR makes the minifier use report_change!() for important messages instead of trace_op!()

Copy link

changeset-bot bot commented Feb 25, 2025

⚠️ No Changeset found

Latest commit: ef6d36b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 self-assigned this Feb 25, 2025
@kdy1 kdy1 marked this pull request as ready for review February 25, 2025 07:34
@kdy1 kdy1 requested a review from a team as a code owner February 25, 2025 07:34
@kdy1 kdy1 added this to the Planned milestone Feb 25, 2025
@kdy1 kdy1 changed the base branch from kdy1/minifier-debug-feature to graphite-base/10091 February 25, 2025 08:00
@kdy1 kdy1 force-pushed the graphite-base/10091 branch from 23148af to 48f68db Compare February 25, 2025 08:00
@kdy1 kdy1 force-pushed the kdy1/minifier-log branch from 982cbc7 to 44dec3b Compare February 25, 2025 08:00
@kdy1 kdy1 changed the base branch from graphite-base/10091 to main February 25, 2025 08:01
@kdy1 kdy1 force-pushed the kdy1/minifier-log branch from 44dec3b to ef6d36b Compare February 25, 2025 08:01
Copy link

codspeed-hq bot commented Feb 25, 2025

CodSpeed Performance Report

Merging #10091 will degrade performances by 5.69%

Comparing kdy1/minifier-log (982cbc7) with main (c345b20)

Summary

❌ 2 regressions
✅ 189 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/moment 104.8 ms 111.1 ms -5.68%
es/minifier/libs/moment 82.7 ms 87.7 ms -5.69%

@kdy1 kdy1 merged commit 9ee79c9 into main Feb 25, 2025
171 of 172 checks passed
Copy link
Member Author

kdy1 commented Feb 25, 2025

Merge activity

  • Feb 25, 5:36 PM GMT+9: A user merged this pull request with Graphite.

@kdy1 kdy1 deleted the kdy1/minifier-log branch February 25, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant