Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/minifier): Use core visitors #10052

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 19, 2025

Description:

I'll try to profile the performance difference and the binary size difference.

Related issue (if exists):

Copy link

changeset-bot bot commented Feb 19, 2025

⚠️ No Changeset found

Latest commit: dd6b6c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codspeed-hq bot commented Feb 19, 2025

CodSpeed Performance Report

Merging #10052 will degrade performances by 5.46%

Comparing kdy1:core-visit-pass (dd6b6c0) with main (c75578b)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 193 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/jquery 167 ms 176.6 ms -5.46%
es/full/minify/libraries/lodash 190.2 ms 183.4 ms +3.66%
es/minifier/libs/terser 398.8 ms 387.1 ms +3.03%

@kdy1 kdy1 added this to the Planned milestone Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant