Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/minifier): Do not clone from take_ident_of_pat_if_unused #10005

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 6, 2025

@kdy1 kdy1 added this to the Planned milestone Feb 6, 2025
@kdy1 kdy1 self-assigned this Feb 6, 2025
@kdy1 kdy1 requested a review from a team as a code owner February 6, 2025 17:42
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 6, 2025
Copy link

changeset-bot bot commented Feb 6, 2025

🦋 Changeset detected

Latest commit: c186bf0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 enabled auto-merge (squash) February 6, 2025 17:42
@kdy1 kdy1 requested a review from a team as a code owner February 6, 2025 17:43
@kdy1 kdy1 merged commit dc3b46e into swc-project:main Feb 6, 2025
171 checks passed
@kdy1 kdy1 deleted the issue-9999 branch February 6, 2025 18:16
Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #10005 will degrade performances by 5.13%

Comparing kdy1:issue-9999 (c186bf0) with main (6f4e7ad)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 194 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/minifier/libs/lodash 197.7 ms 208.4 ms -5.13%
es/minifier/libs/moment 105.1 ms 102 ms +3.06%

@kdy1 kdy1 modified the milestones: Planned, v1.10.15 Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

es/minifier: take_ident_of_pat_if_unused should not clone Box<VarUsageInfo>
1 participant