Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Inline before cost analysis #10092

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 25, 2025

Description:

Previously, cost analysis could be wrong for inputs like

            function na(e, t, a) {
                return o(t);

                function o(m) {
                    return a1(m) && m.pos === e.end ? m : gv(m.getChildren(a), v => (v.pos <= e.pos && v.end > e.end || v.pos === e.end) && yv(v, a) ? o(v) : void 0)
                }
            }

Copy link

changeset-bot bot commented Feb 25, 2025

🦋 Changeset detected

Latest commit: b115686

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 self-assigned this Feb 25, 2025
@kdy1 kdy1 force-pushed the kdy1/minifier-cost-fix branch from 4ceb761 to b6881ce Compare February 25, 2025 07:34
@kdy1 kdy1 changed the title fix log bug fix(es/minifier): Inline before cost analysis Feb 25, 2025
@kdy1 kdy1 marked this pull request as ready for review February 25, 2025 07:36
@kdy1 kdy1 requested a review from a team as a code owner February 25, 2025 07:36
@kdy1 kdy1 added this to the Planned milestone Feb 25, 2025
@kdy1 kdy1 force-pushed the kdy1/minifier-cost-fix branch from b6881ce to 32e7dd9 Compare February 25, 2025 07:38
@kdy1 kdy1 requested a review from a team as a code owner February 25, 2025 07:39
@kdy1 kdy1 force-pushed the kdy1/minifier-log branch 2 times, most recently from 44dec3b to ef6d36b Compare February 25, 2025 08:01
@kdy1 kdy1 force-pushed the kdy1/minifier-cost-fix branch from 2c63872 to 9aded2c Compare February 25, 2025 08:01
@kdy1 kdy1 changed the base branch from kdy1/minifier-log to graphite-base/10092 February 25, 2025 08:36
@kdy1 kdy1 force-pushed the graphite-base/10092 branch from ef6d36b to 9ee79c9 Compare February 25, 2025 08:36
@kdy1 kdy1 force-pushed the kdy1/minifier-cost-fix branch from 9aded2c to 5932a32 Compare February 25, 2025 08:36
@kdy1 kdy1 changed the base branch from graphite-base/10092 to main February 25, 2025 08:37
@kdy1 kdy1 force-pushed the kdy1/minifier-cost-fix branch from 5932a32 to b115686 Compare February 25, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant