Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es/minifier): Inline across side-effect-free member exprs, #10056

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

Austaras
Copy link
Member

@Austaras Austaras commented Feb 20, 2025

Description:

This is safe even in presence of impure setter because JS eval rhs before setter

({ set a(v) { console.log(v) }}).a = (console.log(1), 2)

would output 1 2

and gcc has this optimization too.

@Austaras Austaras requested a review from a team as a code owner February 20, 2025 03:54
Copy link

changeset-bot bot commented Feb 20, 2025

🦋 Changeset detected

Latest commit: 1831c0f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 added this to the Planned milestone Feb 20, 2025
@kdy1 kdy1 requested a review from a team as a code owner February 20, 2025 15:43
@kdy1 kdy1 changed the title feat(es/minifier): Seq inline across side effect free member feat(es/minifier): Inline across side-effect-free member exprs, Feb 20, 2025
@kdy1 kdy1 merged commit 19d01d7 into swc-project:main Feb 20, 2025
19 checks passed
Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #10056 will degrade performances by 4.59%

Comparing Austaras:main (1831c0f) with main (e78b9d1)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 189 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/jquery 173.8 ms 167.8 ms +3.57%
es/minifier/libs/lodash 152.7 ms 160.1 ms -4.59%

@kdy1 kdy1 modified the milestones: Planned, v1.11.1 Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants