Skip to content

Commit

Permalink
chore(swc_allocator): Remove nightly from default feature (#10058)
Browse files Browse the repository at this point in the history
**Description:**

It disturbs moving some types to arena allocator
  • Loading branch information
kdy1 authored Feb 20, 2025
1 parent c75578b commit e78b9d1
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 10 deletions.
6 changes: 6 additions & 0 deletions .changeset/shiny-fireants-smile.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
swc_core: patch
swc_allocator: patch
---

chore(swc_allocator): Remove `nightly` from default feature
12 changes: 6 additions & 6 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions crates/swc_allocator/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ version = "3.0.0"


[features]
default = ["scoped", "rkyv"]
default = []
nightly = ["bumpalo/allocator_api", "hashbrown/nightly"]
rkyv = ["dep:rkyv", "dep:rancor"]
scoped = ["nightly"]
Expand Down Expand Up @@ -43,5 +43,6 @@ swc_malloc = { version = "1.0.0", path = "../swc_malloc" }


[[bench]]
harness = false
name = "bench"
harness = false
name = "bench"
required-features = ["nightly"]
2 changes: 2 additions & 0 deletions crates/swc_allocator/tests/alloction.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![cfg(feature = "nightly")]

use criterion::black_box;
use swc_allocator::{boxed::Box, Allocator, FastAlloc};

Expand Down
2 changes: 1 addition & 1 deletion scripts/bench/list-crates-with-bench.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
set -eu

WS_CRATES=$(./scripts/cargo/get-workspace-crates-json.sh)
echo "$WS_CRATES" | jq -r -c '[.[] | select(.targets[] | .kind | contains(["bench"])) | .name] | sort | unique' | jq -r -c '[.[] | select(. != "swc_plugin_runner")]'
echo "$WS_CRATES" | jq -r -c '[.[] | select(.targets[] | .kind | contains(["bench"])) | .name] | sort | unique' | jq -r -c '[.[] | select(. != "swc_plugin_runner" and . != "swc_allocator")]'

0 comments on commit e78b9d1

Please sign in to comment.