Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from TravisCI to Github Actions #120

Closed

Conversation

westonganger
Copy link
Contributor

Switch from TravisCI to Github Actions so that we have a CI suite again

This github workflow was extracted from one of my many gems so it should be basically ready to go.

I have changed the tests to only run against sqlite as I think this gem is totally database independent. If we want to test against mysql or pg its just simple changes to the the following files: .github/workflow/test.yml, Appraisals, Gemfile

@timfjord
Copy link
Collaborator

Thanks for the contribution @westonganger

I was thinking about this switch but as far as I remember I wasn't able to do that because I didn't have proper permissions.

I would like to keep all DBs, but before even start discussing that I want to understand if I am able to activate Actions for the repo

@westonganger westonganger mentioned this pull request Oct 21, 2021
@timfjord
Copy link
Collaborator

I've checked everything and I can enable Github Actions, which is great
But I want to go a bit different way, in particular

  • I want all DBs as it was in Travis
  • I am not 100% sure about Appraisals as we have something similar but very very simple and I would rather give it a go

I am going to close this PR as it will be simpler to play with the setup on my own(in this PR #124) rather than requesting changes here

@timfjord timfjord closed this Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants