Caching #122
Merged
Caching #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfjord
reviewed
Oct 19, 2021
|
Ok now mostly all tests are passing. There are only 3 tests failing on test/missing_cached_test.rb due to the issues stated on #106 |
timfjord
requested changes
Oct 20, 2021
timfjord
reviewed
Oct 21, 2021
|
@westonganger I was thinking about the caching tests and I would like to handle them a bit differently Please merge the PR so I can merge this PR afterwards as it looks good to me(except the tests part) |
Use another approach for caching tests
timfjord
approved these changes
Oct 25, 2021
|
@westonganger Thanks for your hard work on this |
|
Impressive work @westonganger be @timfjord ! Thank you for continuing and finish this change :) |
ddarren
pushed a commit
to visit-widget/i18n-active_record
that referenced
this pull request
Dec 28, 2021
Co-authored-by: Stanislas Chevallier <[email protected]> Co-authored-by: Tim Masliuchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the work from PR #110
The tests are not all passing yet