chore: more signal fine-tuning #9531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f8b892e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trueadm
force-pushed
the
tune-signals-2
branch
from
cfdf865 to
16d84e4
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dummdidumm
reviewed
Nov 18, 2023
| value: V; | ||
| }; | ||
|
|
||
| export type ComputationSignal<V = unknown> = { |
There was a problem hiding this comment.
Is this an extension of the Signal interface? If so, should we make these interfaces so we can use extends?
There was a problem hiding this comment.
There is no Signal interface. Signal is a union of the two shapes.
There was a problem hiding this comment.
Sorry I meant SourceSignal, which looks like a strict subset of ComputationSignal
gtm-nayan
reviewed
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than having a single monomorphic signal object, it can be just as fast two have two object shapes. This also reduces memory usage as the source signal shape can be cheaper.